feat(examples): support @adcp/sdk 7.10 storyboards#783
Conversation
|
Triage status: this external draft is conflicting with main. Maintainer edits are enabled, but because it touches CI, changelog, and multi-platform seller behavior, I am not resolving it opportunistically in the general triage pass. Recommended path: author rebases and updates the draft, or we explicitly take over this PR in a focused CI/storyboard compatibility pass. |
|
Acknowledged. Deferring to the author-rebase path — lighter-weight and keeps authorship intact. If @sangilish doesn't rebase within a reasonable window and a maintainer wants an explicit takeover, a Triaged by Claude Code. Generated by Claude Code |
|
Thanks for the triage. I’m closing this stale draft rather than asking maintainers to resolve the conflict set. #782 was completed by #788 on the current 7.10.2 path, and the remaining multi-platform seller changes here are broader than the original issue scope. If there is still a current-main gap in the multi-platform seller example, I’ll split that into a smaller focused PR with fresh validation. |
|
Acknowledged — closing this draft makes sense given #788 already landed the 7.10.2 path. A smaller, focused PR for any remaining multi-platform seller gap sounds like the right approach. Triaged by Claude Code. Session: https://claude.ai/code/session_01EsZiiRC1Zz656H4Y2DTuiT Generated by Claude Code |
2 participants
Summary
Refs #782.
This moves the example storyboard jobs to
@adcp/sdk@7.10.1and catches the multi-platform seller example up to the stricter 7.10 storyboard checks.What changed
ADCP_SDK_VERSION: "7.10.1"workflow pin and versioned npm cache keys for all storyboard jobs.list_accountssupport to the multi-platform demo account store so sales specialisms advertise an account-discovery tool.format_id, honorlist_creativescreative-id filters, and returnNOT_CANCELLABLEfor repeated cancellation.Testing
uv run pytest tests/ -q— 4943 passed, 34 skipped, 9 deselected, 1 xfaileduv run ruff check examples/multi_platform_seller/src/account_store.py examples/multi_platform_seller/src/mock_guaranteed.py examples/multi_platform_seller/src/mock_non_guaranteed.py tests/test_multi_platform_seller_example.pyuv run mypy src/adcp/adcp storyboard run http://127.0.0.1:3001/mcp media_buy_seller --json --allow-httpwith@adcp/sdk@7.10.1— passing, 57 passed / 0 failedadcp storyboard run http://tenant-a.localhost:3001/mcp media_buy_seller --json --allow-httpwith@adcp/sdk@7.10.1— passing, 31 passed / 0 failedadcp storyboard run http://tenant-b.localhost:3001/mcp media_buy_seller --json --allow-httpwith@adcp/sdk@7.10.1— passing, 31 passed / 0 failedadcp storyboard run http://127.0.0.1:3003/mcp media_buy_seller/proposal_finalize --json --allow-httpwith@adcp/sdk@7.10.1— passing, 5 passed / 0 failedadcp storyboard run http://acme.localhost:3001/mcp media_buy_seller --auth dev-bearer-token-acme-1 --json --allow-httpwith@adcp/sdk@7.10.1and local Postgres/mock-server — passing, 32 passed / 0 failed; upstream traffic total 44Draft until GitHub Actions confirms the full matrix.